classes/controllers/FrmFormActionsController.php (1)

139-143: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Fix nullable iteration to unblock Psalm.

self::$registered_actions is nullable by type, so iterating self::$registered_actions->actions at Line 139 triggers the current pipeline failure (PossiblyNullIterator).

Proposed fix

-		foreach ( self::$registered_actions->actions as $action ) {
+		$registered_actions = self::$registered_actions ? self::$registered_actions->actions : array();
+		foreach ( $registered_actions as $action ) {
 			if ( $action->action_options['description'] === '' && isset( $descriptions[ $action->id_base ] ) ) {
 				$action->action_options['description'] = $descriptions[ $action->id_base ];
 			}
 		}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@classes/controllers/FrmFormActionsController.php` around lines 139 - 143,
FrmFormActionsController currently iterates self::$registered_actions->actions
while self::$registered_actions is nullable, causing a PossiblyNullIterator
error; guard the loop by ensuring self::$registered_actions is not null and that
the actions collection exists (e.g., check self::$registered_actions !== null
and isset(self::$registered_actions->actions) or use the null-coalescing pattern
to iterate an empty array when actions is absent) before running the foreach
over $action so that $action->action_options['description'] assignment and
checks against $descriptions[$action->id_base] are only executed when a valid
actions iterable is present.

classes/helpers/FrmAppHelper.php (1)

4047-4066: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Include PayPal in connected-gateway modal copy.

When only PayPal is connected, implode() receives an empty list and Line 4057 produces broken text; the fallback copy on Line 4065 also still excludes PayPal.

Proposed fix

 		if ( $gateway_connected ) {
 			$gateway_texts = array();
@@
 			if ( $square_connected ) {
 				$gateway_texts['square'] = esc_html__( 'Square', 'formidable' );
 			}
+			if ( $paypal_connected ) {
+				$gateway_texts['paypal'] = esc_html__( 'PayPal', 'formidable' );
+			}
 
 			$admin_script_strings['pricingFieldsModal']['msg'] = sprintf(
-				// translators: %s: Stripe or Square.
+				// translators: %s: Connected gateway names.
 				esc_html__( 'You already have %s connected, so these have already been unlocked.', 'formidable' ),
 				esc_html( implode( ' ' . esc_html__( 'and', 'formidable' ) . ' ', $gateway_texts ) )
 			);
@@
-			$admin_script_strings['pricingFieldsModal']['msg'] = __( 'We\'ve unlocked Product, Quantity, and Total fields for Lite users! You can now transform your forms into checkout pages. To start collecting revenue, simply connect your preferred payment gateway (Stripe, or Square) in your settings.', 'formidable' );
+			$admin_script_strings['pricingFieldsModal']['msg'] = __( 'We\'ve unlocked Product, Quantity, and Total fields for Lite users! You can now transform your forms into checkout pages. To start collecting revenue, simply connect your preferred payment gateway (Stripe, Square, or PayPal) in your settings.', 'formidable' );
 		}//end if

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@classes/helpers/FrmAppHelper.php` around lines 4047 - 4066, The modal copy
fails to include PayPal and can produce an empty implode result; update the
connected-gateway branch to also check the PayPal flag (e.g. $paypal_connected)
and add $gateway_texts['paypal'] = esc_html__( 'PayPal', 'formidable' ) when
set, and update the fallback message assigned to
$admin_script_strings['pricingFieldsModal']['msg'] to mention PayPal alongside
Stripe and Square; ensure the sprintf that builds
$admin_script_strings['pricingFieldsModal']['msg'] uses the populated
$gateway_texts (e.g. implode( ' ' . esc_html__( 'and', 'formidable' ) . ' ',
$gateway_texts )) so it no longer produces blank output when PayPal is the only
connected gateway.

classes/helpers/FrmAppHelper.php (1)

4044-4065: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Include PayPal in the pricing-fields modal copy.

$gateway_connected now treats PayPal as connected, but this branch still builds the connected-gateway list from Stripe/Square only and the fallback CTA still names only Stripe/Square. If PayPal is the only configured gateway, %s renders empty here; if nothing is configured, the copy hides a valid option.

Suggested fix

 		if ( $gateway_connected ) {
 			$gateway_texts = array();
 
 			if ( $stripe_connected ) {
 				$gateway_texts['stripe'] = esc_html__( 'Stripe', 'formidable' );
 			}
 
 			if ( $square_connected ) {
 				$gateway_texts['square'] = esc_html__( 'Square', 'formidable' );
 			}
+
+			if ( $paypal_connected ) {
+				$gateway_texts['paypal'] = esc_html__( 'PayPal', 'formidable' );
+			}
 
 			$admin_script_strings['pricingFieldsModal']['msg'] = sprintf(
-				// translators: %s: Stripe or Square.
+				// translators: %s: Connected payment gateways.
 				esc_html__( 'You already have %s connected, so these have already been unlocked.', 'formidable' ),
 				esc_html( implode( ' ' . esc_html__( 'and', 'formidable' ) . ' ', $gateway_texts ) )
 			);
 		} else {
@@
-			$admin_script_strings['pricingFieldsModal']['msg'] = __( 'We\'ve unlocked Product, Quantity, and Total fields for Lite users! You can now transform your forms into checkout pages. To start collecting revenue, simply connect your preferred payment gateway (Stripe, or Square) in your settings.', 'formidable' );
+			$admin_script_strings['pricingFieldsModal']['msg'] = __( 'We\'ve unlocked Product, Quantity, and Total fields for Lite users! You can now transform your forms into checkout pages. To start collecting revenue, simply connect your preferred payment gateway (Stripe, Square, or PayPal) in your settings.', 'formidable' );
 		}//end if

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@classes/helpers/FrmAppHelper.php` around lines 4044 - 4065, The pricing modal
builds the connected gateway list and fallback CTA text from only
$stripe_connected and $square_connected, causing %s to be empty when PayPal is
the only configured gateway; update the logic in the block that populates
$gateway_texts and the fallback CTA message (references: $gateway_connected,
$stripe_connected, $square_connected, $gateway_texts,
$admin_script_strings['pricingFieldsModal']['msg'] and ['actionText']) to also
check for the PayPal flag (e.g. $paypal_connected or whichever variable tracks
PayPal) and add esc_html__( 'PayPal', 'formidable' ) into $gateway_texts, and
update the fallback CTA copy to mention PayPal alongside Stripe and Square so
the imploded list and messages include PayPal when applicable.

paypal/controllers/FrmPayPalLiteActionsController.php (1)

1116-1116: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Fix type error: cast $amount to float for number_format().

Psalm is failing because parent::prepare_amount() returns a string, but number_format() expects a float as the first argument.

🐛 Proposed fix

-		return number_format( $amount, $currency['decimals'], '', '' );
+		return number_format( (float) $amount, $currency['decimals'], '', '' );

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@paypal/controllers/FrmPayPalLiteActionsController.php` at line 1116, The
return uses number_format($amount, ...) but parent::prepare_amount() returns a
string, causing a type error; cast the value to float before passing to
number_format (e.g., cast the result of parent::prepare_amount() or $amount to
(float)) so number_format receives a float; update the return in
FrmPayPalLiteActionsController (where number_format is called) to use
(float)$amount or cast the call to parent::prepare_amount() to float.